-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Sharing Wishlist with more than allowed Text Length Limit #28812
MFTF: Sharing Wishlist with more than allowed Text Length Limit #28812
Conversation
Hi @DmitryTsymbal. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contribution is fine, but after verifying error you can add steps to verify if after amends it works properly. Why? Sometimes the validators get stuck with some js / session data issues
<createData entity="SimpleProduct" stepKey="createProduct"> | ||
<requiredEntity createDataKey="createCategory"/> | ||
</createData> | ||
<magentoCLI command="cron:run --group=index" stepKey="runCronIndexer"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have magentoCron command available 👍
Hi @lbajsarowicz, thank you for the review.
|
Hi @dmytro-ch, thank you for the review. |
@magento create issue |
Notice: QA not applicable |
@magento run all tests |
Hi @DmitryTsymbal, thank you for your contribution! |
This PR contains a test for sharing customer's wishlist with more than allowed Text Length Limit
Steps to reproduce:
1 - Set maximum allowed Text Length Limit for sharing
2 - Login as a customer
3 - Add product into wishlist
4 - Share wishlist with more than maximum allowed Text Length Limit
5 - Perform Assertions
Resolved issues: